Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an auth filter for PinDeploy pipeline #1719

Merged
merged 8 commits into from
Oct 2, 2024
Merged

Conversation

tylerwowen
Copy link
Contributor

@tylerwowen tylerwowen commented Sep 24, 2024

This PR implements an auth filter that will replace the principal if both of the conditions are met

  1. Request is sent from a list of spiffe ids
  2. Request contains a special header.
  3. Because the principal name has a SPIFFE prefix, it's more likely to exceed the DB column limit. Introduced a method to trim the string to avoid updating the DB.

Test and validations

test coverage and some manual tests

  1. Start the service with updated configuration
  2. Craft a request with the spiffe ID and special header
  3. Verify in the debugger that the principal is replaced.

@tylerwowen tylerwowen requested a review from a team as a code owner September 24, 2024 22:15
@github-actions github-actions bot added the deploy-service Includes changes to deploy-service label Sep 24, 2024
@tylerwowen tylerwowen merged commit d6258b0 into master Oct 2, 2024
6 checks passed
@tylerwowen tylerwowen deleted the touyang/pindeploy_authn branch October 2, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-service Includes changes to deploy-service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants